[lexical-mark] Bug Fix: Stop MarkNode __ids array deep copy in clone #6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addId and deleteId functions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ebads67
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
ivailop7
previously approved these changes
Nov 8, 2024
etrepum
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
LGTM, maybe a little more defensive than it needs to be, although this maintains type compatibility externally. The $isMarkNode(self) checks are useless if you wanted to simplify further, I can only imagine they are there from a time when this.getLatest() and this.getWritable() had the wrong types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR creation of a new
__idsarray is avoided in the clone function of the MarkNode, and the cloned MarkNode will have the same reference to__idsarray of the original node. This has made an issue in thesyncPropertiesFromYjsfunction where we compare the old and new nodes' properties, and only make an update to ydoc if the properties are changed. In the case MarkNodes, because the clone function deep-copies the__idsarray the property comparison detects a change, despite the arrays being identical.The fix is keeping the same
__idsarray in the cloned node, and only creating new__idsarray when the array is modified.