fix: preserve custom fields in Lexical-Yjs sync #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syncing Lexical selection to Yjs, custom fields in the local state were being dropped. This commit ensures all custom fields are preserved during the sync process, maintaining data integrity in collaborative editing scenarios. Updated syncLexicalSelectionToYjs to include ...customFields Ensures backwards compatibility with existing implementations Improves reliability of custom data persistence in collaboration
collierrgbsitisfise
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
previously approved these changes
Oct 12, 2024
| @@ -531,6 +532,7 @@ export function syncLexicalSelectionToYjs( | |||
| focusPos, | |||
| focusing, | |||
| name, | |||
| ...customFields, | |||
There was a problem hiding this comment.
It would be a bit more efficient to use localState instead, the customFields variable isn't needed:
awareness.setLocalState({
...localState,
anchorPos,
awarenessData,
color,
focusPos,
focusing,
name,
});There was a problem hiding this comment.
@etrepum make sense, fixed!
etrepum
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing Lexical selection to Yjs, custom fields in the local state were being dropped. This commit ensures all custom fields are preserved during the sync process, maintaining data integrity in collaborative editing scenarios.
Updated syncLexicalSelectionToYjs to include ...customFields Ensures backwards compatibility with existing implementations Improves reliability of custom data persistence in collaboration
prev PR where ProviderAwareness type was extended with
setLocalStateField