[lexical-playground] Bug Fix: Track Resizing Actions for Excalidraw in History Stack #6696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Behaviour
Excalidraw resizing actions are not tracked. My understanding of this is that because the component is fetching width and height from the editor state rather than receiving them as props, React didn't detect the changes to width and height, preventing the component from rerendering on resizing. And as a result, Lexical did not record these transactions in its history stack.
Changes Introduced
I am now passing in the width and height properties as props into ExcalidrawComponent, similar to what is done in ImageNode. And I got rid of useMemo.
Before
excal_resize_before.mov
After
excal_resize_after.mov
Tested in collab mode as well.