[lexical-link] Bug Fix: Removing a link from descendants #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levensta
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
The logic looks like it's probably correct, but it would be nice to have a bit of test coverage!
There's probably some efficiency that could be gained by checking only the anchor and focus parents, otherwise the LinkNode itself would be present in the selection's nodes.
|
+1 on a test covering this use case |
potatowagon
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
looks good to merge! have noted the test case addition todo here: #6665
potatowagon
added
the
test-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment it is possible to delete LinkNode only when children are TextNode. But if there is another node inside the link above the text, deletion will not work.
With this PR I fix this behavior and show how it works using the MarkNode example (via adding a comment) in lexical-playground
Test plan
Before
before.mov
After
after.mov