Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-markdown]: Refactor: allows omitting certain properties from TextMatchTransformers, adds jsdocs #6651

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[lexical-markdown]: Refactor: allows omitting certain properties from TextMatchTransformers, adds jsdocs #6651

merged 2 commits into from
Sep 20, 2024

Conversation

AlessioGr
Copy link
Contributor

In my project, I have a TextMatchTransformer that I use solely for node => markdown string exports. For markdown string => node imports I'm using Multiline markdown transformers.

In order to accommodate this without having to pass fake stub properties to the TextMatchTransformer, this PR makes all properties optional.

Also added some much-needed JSDocs for this interface

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:11am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:11am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.85 KB (0%)
lexical - esm 29.66 KB (0%)
@lexical/rich-text - cjs 38.3 KB (0%)
@lexical/rich-text - esm 31.55 KB (0%)
@lexical/plain-text - cjs 36.9 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.04 KB (0%)
@lexical/react - esm 32.91 KB (0%)

etrepum
etrepum approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, I did notice this last time I used the markdown implementation

@etrepum
Copy link
Collaborator

etrepum commented Sep 20, 2024

The integration test failure is fixed by #6652

@potatowagon potatowagon added the extended-tests Run extended e2e tests on a PR label Sep 20, 2024
@potatowagon potatowagon added this pull request to the merge queue Sep 20, 2024
Merged via the queue into facebook:main with commit 1469aa7 Sep 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlessioGr @etrepum @facebook-github-bot @potatowagon