Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting a document fragment from the exportDOM function #6641

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

skopz356
Copy link
Contributor

Closes #5238

This PR allows a node's exportDOM function to return a DocumentFragment in addition to a HTMLElement or TextNode, which allows exporting a collection of elements with no wrapping element from that node.

See the linked issue for more details, but my basic use case is being able to remove a wrapping anchor tag from the HTML output if the href property is invalid, but keep any formatting (such as tags) within that anchor tag.

Based on: #5288

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:09am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:09am

@facebook-github-bot
Copy link
Contributor

Hi @skopz356!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

size-limit report 📦

Path Size
lexical - cjs 29.78 KB (0%)
lexical - esm 29.62 KB (0%)
@lexical/rich-text - cjs 38.21 KB (0%)
@lexical/rich-text - esm 31.51 KB (0%)
@lexical/plain-text - cjs 36.87 KB (0%)
@lexical/plain-text - esm 28.82 KB (0%)
@lexical/react - cjs 40.01 KB (0%)
@lexical/react - esm 32.91 KB (0%)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 18, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests are passing!

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Sep 18, 2024
@etrepum etrepum added this pull request to the merge queue Sep 18, 2024
Merged via the queue into facebook:main with commit fc8cf09 Sep 18, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow exportDOM to return a DocumentFragment
3 participants