-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table][lexical-playground] Bug Fix: Fix merged cell related edge cases #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leSelection.getShape accounts for span
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 6, 2024
size-limit report 📦
|
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
September 6, 2024 21:02
etrepum
changed the title
[WIP] [lexical-table][lexical-playground] Bug Fix: Fix merged cell related edge cases
[lexical-table][lexical-playground] Bug Fix: Fix merged cell related edge cases
Sep 6, 2024
Closed
11 tasks
Great work @etrepum, this is a massive improvement to table cell merging. |
ivailop7
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic step forward! Thank you for putting in the effort in fixing up tables!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
tables
Relates to Lexical Tables
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TableSelection.getNodes
returns each node at most once, which fixes logic errors in merge code when the "first cell" shows up multiple times due to mergecolSpan
androwSpan
inTableSelection.getShape
TableCellNode
$computeTableMapSkipCellCheck
for non-rectangular tables with rowSpan below the last<tr>
in the table. Someone who cares more about these edge cases with what is essentially a bad input should put some more work into this though, since there are likely still other edge cases. TheTableMapType
and its associated functions (e.g.$computeTableMap
) really should get tossed, it's not a good abstraction and it can't represent a non-rectangular table, but because the types are fully transparent it can't be fixed in-place in a backwards compatible way./cc @ivailop7
Closes #6599
Closes #4470
Closes #5853
Closes #6605
Closes #6584
Test plan
Before
After