Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] Bug Fix: Add @lexical/clipboard as a direct dependency of @lexical/table #6571

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Aug 28, 2024

Description

0.17.1 added a @lexical/clipboard dependency in @lexical/table but it was not declared in package.json

Closes #6569

Test plan

Before

Undeclared dependencies in @lexical/table could potentially cause a package manager to generate an incorrect lockfile

After

It should no longer be possible for that error to occur

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 2:18pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 2:18pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2024
@etrepum etrepum changed the title [lexical-table] Add @lexical/clipboard as a direct dependency of @lexical/table [lexical-table] Bug Fix: Add @lexical/clipboard as a direct dependency of @lexical/table Aug 28, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.22 KB (0%)
@lexical/rich-text - cjs 37.87 KB (0%)
@lexical/rich-text - esm 31.08 KB (0%)
@lexical/plain-text - cjs 36.45 KB (0%)
@lexical/plain-text - esm 28.44 KB (0%)
@lexical/react - cjs 39.61 KB (0%)
@lexical/react - esm 32.5 KB (0%)

@ivailop7 ivailop7 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into facebook:main with commit 0683d58 Aug 28, 2024
22 checks passed
@etrepum etrepum deleted the table-clipboard-dependency branch August 28, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: updating from lexical packages 1.17.0 -> 1.17.1 raises errors in CI for @lexical/table
3 participants