[lexical-table] Bug Fix: Append a ParagraphNode to each cell when unmerging #6556
Conversation
kmslab20
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @kmslab20! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
size-limit report 📦
|
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@kmslab20 Thank you for fixing this. Could you add a test please, happy to merge once you've added the test for this. |
|
@ivailop7 I slightly modified the merge/unmerge test code in the Table test, and added a new test relevant to this PR🙂 |
Description
ParagraphNodes(p tag) are missing in the unmerged cells, except fot the first one.
Some behaviors like pasting or inserting a new line in the cells do not work. This fix appends a ParagraphNode to each cell when unmerging.
Closes #6552
Test plan
Before
_2024_08_26_00_34_41_845.mp4
After
_20240826_195012.mp4