[lexical-table] Fix table selection paste as plain text #6548
Conversation
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
changed the title
size-limit report 📦
|
One of the more popular editors I tried does it this way - cell per new line, which I think makes more sense to manipulate further if one wanted the output as plain text. Another one I tried does it the way you decribed. I don't mind chaning the paste structure, I'm unsure on the right output layout. |
|
The default behavior of the browser is to copy tables with tabs delimiting cells and newlines delimiting rows |
updated, updated.movI'm sure there's a more elegant way to concat correctly, but it does the job. |
| const row = node.__parent; | ||
| const nextRow = (nodes[i + 1] || {}).__parent; | ||
| textContent += | ||
| (node.getTextContent() || ' ') + (nextRow !== row ? '\n' : '\t'); |
There was a problem hiding this comment.
I don't think the || ' ' matches browser expectations (when I tried it with a table the browser doesn't insert whitespace that isn't in the content, other than the delimiters) but the rest looks good to me. Would be nice to have some tests!
There was a problem hiding this comment.
updated, added a test
Fixes #6541
Before:
Double pasting incorrectly, since it was reading all nodes - rows and cells.
before_table_paste_plaintext.mov
After:
Pasting correctly, since reading only cells.
after_table_paste_plaintext.mov