Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Bug Fix: Fix firefox e2e test regression in Selection.spec.mjs #6546

Merged
merged 4 commits into from
Aug 24, 2024
Merged

[lexical-playground] Bug Fix: Fix firefox e2e test regression in Selection.spec.mjs #6546

merged 4 commits into from
Aug 24, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Aug 23, 2024 •
edited
Loading

Description

Fix firefox e2e test regression at packages/lexical-playground/tests/e2e/Selection.spec.mjs:651:3 (added in #6542, unclear what else in the merge queue caused this to happen?)

Test plan

Before

e2e tests fail in unrelated PRs

After

e2e tests pass

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Aug 23, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2024 0:00am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2024 0:00am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.74 KB (0%)
@lexical/rich-text - esm 31.05 KB (0%)
@lexical/plain-text - cjs 36.41 KB (0%)
@lexical/plain-text - esm 28.42 KB (0%)
@lexical/react - cjs 39.61 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@etrepum etrepum marked this pull request as ready for review August 24, 2024 00:14
@etrepum etrepum mentioned this pull request Aug 24, 2024
Closed
@ivailop7 ivailop7 added this pull request to the merge queue Aug 24, 2024
Merged via the queue into facebook:main with commit 365f91f Aug 24, 2024
41 checks passed
@tristanrobert tristanrobert mentioned this pull request Sep 28, 2024
Closed
This was referenced Sep 28, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etrepum @ivailop7 @facebook-github-bot