Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-react] Fix: Fix React.startTransition on Webpack + React 17 #6517

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

turnerguo
Copy link
Contributor

Description

  • Webpack + React 17 fails to compile on the usage of React.startTransition or React["startTransition"]

Closes #6516

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 6:43am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 6:43am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.74 KB (0%)
@lexical/rich-text - esm 31.05 KB (0%)
@lexical/plain-text - cjs 36.41 KB (0%)
@lexical/plain-text - esm 28.42 KB (0%)
@lexical/react - cjs 39.59 KB (0%)
@lexical/react - esm 32.53 KB (0%)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to extract this into a shared module since it's used in multiple places and it would make it easier if it needs to be used again

@turnerguo
Copy link
Contributor Author

turnerguo commented Aug 14, 2024

It probably makes sense to extract this into a shared module since it's used in multiple places and it would make it easier if it needs to be used again

yes, should be fixed. consider for better compatibility of react versions, it may some more patches coming later so just create a new reactPatches file for this, any react patches should be collected in this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Webpack + React 17 fails to compile on the usage of React.startTransition or React["startTransition"]
3 participants