Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical][CI] ignore running unit/integerity/e2e tests on examples folder code #6446

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jul 23, 2024

Description

  • ignore running unit/integerity/e2e tests on examples folder code
  • examples are not impacting the real package code and shouldn't be triggering running of e2e/unit tests, similar to website

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 4:25am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 4:25am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 28.86 KB (0%)
lexical - esm 28.73 KB (0%)
@lexical/rich-text - cjs 37.24 KB (0%)
@lexical/rich-text - esm 28.18 KB (0%)
@lexical/plain-text - cjs 35.85 KB (0%)
@lexical/plain-text - esm 25.49 KB (0%)
@lexical/react - cjs 39.14 KB (0%)
@lexical/react - esm 29.62 KB (0%)

Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm iirc integrity runs the npm run ci-check which runs prettier, would that be relevant for website and example code?

@Sahejkm
Copy link
Contributor Author

Sahejkm commented Jul 23, 2024

hmm iirc integrity runs the npm run ci-check which runs prettier, would that be relevant for website and example code?

yea that would make sense, but right now looks like the pretty check is coupled with tests workflow, might need to take it out in a separate PR

@Sahejkm Sahejkm added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 1b97d9f Jul 23, 2024
40 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants