Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground][TableCellResizer] Bug Fix: Register event handlers on root element #6416

Merged
merged 3 commits into from
Jul 20, 2024
Merged

[lexical-playground][TableCellResizer] Bug Fix: Register event handlers on root element #6416

merged 3 commits into from
Jul 20, 2024

Conversation

JBWereRuss
Copy link
Contributor

@JBWereRuss JBWereRuss commented Jul 18, 2024 •
edited
Loading

The TableCellResizer plugin registers mouse events on the document, but if there are multiple editors on the page they all receive events causing the inactive editors to throw TableCellResizer: Table cell node not found. errors and leading to the inactive editors becoming unresponsive.

Changed the plugin to register events on the editors root element so that events are only raised and handled by the editor the mouse is over.

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 11:23pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 11:23pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 28.76 KB (0%)
lexical - esm 28.61 KB (0%)
@lexical/rich-text - cjs 37.2 KB (0%)
@lexical/rich-text - esm 28.21 KB (0%)
@lexical/plain-text - cjs 35.85 KB (0%)
@lexical/plain-text - esm 25.5 KB (0%)
@lexical/react - cjs 39.12 KB (0%)
@lexical/react - esm 29.49 KB (0%)

@JBWereRuss JBWereRuss changed the title TableCellResizer register event handlers on root element [lexical-playground][TableCellResizer] Fix: Register event handlers on root element Jul 18, 2024
@JBWereRuss JBWereRuss changed the title [lexical-playground][TableCellResizer] Fix: Register event handlers on root element [lexical-playground][TableCellResizer] Bug Fix: Register event handlers on root element Jul 18, 2024
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jul 20, 2024
@ivailop7 ivailop7 added this pull request to the merge queue Jul 20, 2024
Merged via the queue into facebook:main with commit 0a3ecf4 Jul 20, 2024
5 of 8 checks passed
@GermanJablo GermanJablo mentioned this pull request Jul 21, 2024
Merged
This was referenced Aug 21, 2024
Closed
Closed
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBWereRuss @ivailop7 @facebook-github-bot