[lexical-html] Feature: support pasting empty block nodes #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
commented
Jul 11, 2024
Comment on lines
-54
to
-72
| { | ||
| expectedHTML: `<p dir="ltr"><span data-lexical-text="true">a</span></p><p dir="ltr"><span data-lexical-text="true">b b</span></p><p dir="ltr"><span data-lexical-text="true">c</span></p><p dir="ltr"><span data-lexical-text="true">z </span></p><p dir="ltr"><span data-lexical-text="true">d e </span></p><p dir="ltr"><span data-lexical-text="true">fg</span></p>`, | ||
| name: 'nested divs', | ||
| pastedHTML: `<div> | ||
| a | ||
| <div> | ||
| b b | ||
| <div> | ||
| c | ||
| <div> | ||
| <div></div> | ||
| z | ||
| </div> | ||
| </div> | ||
| d e | ||
| </div> | ||
| fg | ||
| </div>`, | ||
| }, |
There was a problem hiding this comment.
moved this to packages/lexical-utils/src/tests/unit/LexicalEventHelpers.test.tsx onPasteFromRichText
because an extra <br /> is introduced in this test setup which i cant repro on the playground or the onPasteFromRichText test env
There was a problem hiding this comment.
codepen
lexical playground
potatowagon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An empty block node (eg.
<div></div>) in between 2 inline nodes in html places the next inline node on the next line, acting as a linebreak. lexical currently doesnt handle pasting empty block nodes, so there is a missing line break where the empty block node should be.see test plan for demo.
test cases are added as unit tests
Test plan
Before
After
Before
After