Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Chore: Use named export of LexicalErrorBoundary in the examples #6378

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[examples] Chore: Use named export of LexicalErrorBoundary in the examples #6378

merged 1 commit into from
Jul 9, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Jul 8, 2024 •
edited
Loading

Description

Looks like #6088 missed rewriting two default imports of LexicalErrorBoundary in the react examples (or there was a regression?)

See also #6253

Test plan

The react-plain-text and react-rich examples should still work.

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:54am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:54am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

@etrepum etrepum marked this pull request as ready for review July 8, 2024 23:52
@Sahejkm Sahejkm added this pull request to the merge queue Jul 9, 2024
Merged via the queue into facebook:main with commit b28e187 Jul 9, 2024
39 of 42 checks passed
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
@etrepum @2wheeh
[examples] Chore: Use named export of LexicalErrorBoundary in the exa…
220d2a0 
…mples (facebook#6378)
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etrepum @Sahejkm @facebook-github-bot