CI: run e2e flaky tests in a separate job #6365
Conversation
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
changed the title
| { | ||
| tag: '@flaky', | ||
| }, |
There was a problem hiding this comment.
only added this, rest are formatting changes
| { | ||
| tag: '@flaky', | ||
| }, |
There was a problem hiding this comment.
only added this, rest are formatting changes
| @@ -402,7 +402,7 @@ function testSuite(charset) { | |||
| await page.focus('div[contenteditable="true"]'); | |||
|
|
|||
| await page.keyboard.type('👨👩👦👦'); | |||
| if (['chromium', 'webkit'].includes(browserName)) { | |||
| if (['chromium', 'webkit', 'firefox'].includes(browserName)) { | |||
There was a problem hiding this comment.
after updating playwright firefox always renders 👨👩👦👦 as 👨👩👦👦
There was a problem hiding this comment.
this makes the below 2 conditions (charset === 'UTF-16' & charset === 'UTF-8') deadcode, any idea what settings to fall into those conditions? as now all 3 browsers render 👨👩👦👦. if no im thinking of removing it
There was a problem hiding this comment.
do we need playwright update in the same PR ?
There was a problem hiding this comment.
yes because playwright update is needed to have tag annotations
| anchorOffset: 2, | ||
| anchorPath: [0, 4, 0, 0], | ||
| focusOffset: 2, | ||
| focusPath: [0, 4, 0, 0], |
There was a problem hiding this comment.
firefox behavior changed after updating playwright
| if (IS_WINDOWS) { | ||
| await assertSelection(page, { | ||
| anchorOffset: 2, | ||
| anchorPath: [0, 1, 0, 0], | ||
| focusOffset: 2, | ||
| focusPath: [0, 1, 0, 0], | ||
| }); | ||
| } else { | ||
| await assertSelection(page, { | ||
| anchorOffset: 2, | ||
| anchorPath: [0, 1, 0, 0], | ||
| focusOffset: 2, | ||
| focusPath: [0, 1, 0, 0], | ||
| }); | ||
| } |
There was a problem hiding this comment.
these 2 are the same so removing the windows condition
| if (charset === 'UTF-16') { | ||
| await assertHTML( | ||
| page, | ||
| html` | ||
| <p | ||
| class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr" | ||
| dir="ltr"> | ||
| <span data-lexical-text="true">👨👩</span> | ||
| <span | ||
| class="PlaygroundEditorTheme__characterLimit PlaygroundEditorTheme__ltr" | ||
| dir="ltr"> | ||
| <span data-lexical-text="true">👦👦</span> | ||
| </span> | ||
| </p> | ||
| `, | ||
| ); | ||
| } else { | ||
| await assertHTML( | ||
| page, | ||
| html` | ||
| <p | ||
| class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr" | ||
| dir="ltr"> | ||
| <span data-lexical-text="true">👨</span> | ||
| <span | ||
| class="PlaygroundEditorTheme__characterLimit PlaygroundEditorTheme__ltr" | ||
| dir="ltr"> | ||
| <span data-lexical-text="true">👩👦👦</span> | ||
| </span> | ||
| </p> | ||
| `, | ||
| ); |
There was a problem hiding this comment.
confirmed with @zurfyx that these can be removed since now FF behaves the same as chrome and webkit
Description
to not run flaky and
to run only flaky
Test plan
Before
see the current status checks in any of the open PRs
After
monitor status checks for this PR
before accept, all checks should pass. for e2e mac canary run the ci run the command with
after accept,
ci pass 100%: https://github.com/facebook/lexical/actions/runs/9775780085/job/26991263423?pr=6365