Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-selection] Fix lost autolink styling #6275

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

MaxPlav
Copy link
Contributor

@MaxPlav MaxPlav commented Jun 7, 2024

Fix bug related to a lost autolink styling. Right away after autolink is created during the user input, the following symbols are inserted without a proper style. This PR fixes that by keeping the style of the newly inserted text node.

Description

Closes #6155

Test plan

  1. Open https://playground.lexical.dev/
  2. Clear the editor
  3. Set font size to anything other than the default 15
  4. Start typing "www.github.com"
  5. See an autolink is created with proper styles.

Before

See #6155

After

Screen.Recording.2024-06-07.at.17.59.08.mov

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 11:01pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 11:01pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.75 KB (0%)
@lexical/rich-text - esm 28.09 KB (0%)
@lexical/plain-text - cjs 35.33 KB (0%)
@lexical/plain-text - esm 25.31 KB (0%)
@lexical/react - cjs 38.54 KB (0%)
@lexical/react - esm 29.17 KB (0%)

@MaxPlav MaxPlav marked this pull request as ready for review June 7, 2024 23:03
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jun 8, 2024
@Sahejkm Sahejkm added this pull request to the merge queue Jun 8, 2024
Merged via the queue into facebook:main with commit 28b3f90 Jun 8, 2024
62 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: AutoLink Styling lost on the last character in the link
4 participants