Bug Fix: Fix selection when hitting "shift+arrowdown" into a table. #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the selection included only up to the first cell and its children, even though the whole table appears selected. We update the logic so that the entire table will actually be selected.
serey-roth
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ivailop7
previously approved these changes
Jun 7, 2024
|
@serey-roth can you recheck the tests, something seems off, I've reran them a couple of times, but fail consistently. |
|
sorry, removing the tag to prevent e2e test on every run, the tests should be triggered on next Approval again automatically. |
ivailop7
previously approved these changes
Jun 17, 2024
serey-roth
force-pushed
the
serey/table/shift+arrowdown
branch
from
6b0197c to
f1dcd4e
Compare
auto-merge was automatically disabled
June 26, 2024 04:15
Head branch was pushed to by a user without write access
ivailop7
approved these changes
Jun 26, 2024
This was referenced Jul 23, 2024
This was referenced Aug 12, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing "Shift+ArrowDown" into a table selects only up to the first table-cell node and its children, even though the whole table appears selected.
Description
Previously, the new focus would be set on the table's parent if the current selection was partially within a table. Now, it will be on the first/last cell of the table.
Closes #6273
Before
screencast-playground.lexical.dev-2024.06.07-14_50_45.webm
After
screencast-localhost_3000-2024.06.07-15_27_25.webm