-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-markdown] Add test to keep code language #6259
Conversation
Hi @Minhir! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Makes sense! Commit with the fix would really help here :P |
Always keep code language.
return language != null && window.Prism.languages.hasOwnProperty(language) | ||
? language | ||
: undefined; | ||
return language ? window.Prism.languages.hasOwnProperty(language) : false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try {
return language ? window.Prism.languages.hasOwnProperty(language) : false;
} catch (error) {
return false
}
this may help the headless editor work in a Web Worker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
[lexical-markdown] Bug Fix: preserve language tag for Markdown code
Right now, PR contains only one commit with tests to highlight the problem.
If the markdown file contains a code block with an unsupported language (a language for which the project doesn't have syntax highlighter) the lexical will remove any information about that language.
Let's say we have markdown with the following content:
If we don't have
prism-rust
in the project, lexical will strip all the info about the language and saved file will look like:That behavior seems to me like a bug.
Possible solution
I think
CodeNode
should always keep__language
field, no matter what themapToPrismLanguage()
returns. And we can create another field called__isSyntaxHighlightSupported
for highlighting check.What do you think? I'll be happy to create another commit with a fix if provided solution works for the lexical team.