[lexical-markdown] Bug Fix: standardise selection to move to start after markdown toggle #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
changed the title
potatowagon
changed the title
potatowagon
commented
Jun 5, 2024
| @@ -189,7 +189,6 @@ export default function ActionsPlugin({ | |||
| $createCodeNode('markdown').append($createTextNode(markdown)), | |||
| ); | |||
| } | |||
| root.selectEnd(); | |||
There was a problem hiding this comment.
after removing this, we expose the selection behavior of $convertFromMarkdownString and $convertToMarkdownString.
$convertToMarkdownString moves the selector (aka cursor) to the start after the markdown -> string conversion.
demo:
Screen.Recording.2024-06-05.at.3.34.06.PM.mov
in this PR adjust $convertFromMarkdownString to do the same. Also the attached issue has raised a preference for having the cursor at the start instead of the end
potatowagon
changed the title
potatowagon
changed the title
Sahejkm
approved these changes
Jun 7, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
standardise the cursor behavior after toggling markdown, it is observed that
$convertToMarkdownStringmoves cursor to the start, so make$convertFromMarkdownStringfollow suit. see #6220 (comment)also, executing @etrepum 's suggestion to add documentation to highlight that the selection (aka cursor) moves after the markdown operation, since it may not be an expected behavior
Closes #6177
Test plan
Before
see video in
https://github.com/facebook/lexical/pull/6220/files#r1627137045
After
Screen.Recording.2024-06-05.at.3.26.41.PM.mov