Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-markdown] Bug Fix: add missing shouldPreserveNewLines to markdown flow #6165

Merged
merged 1 commit into from
May 23, 2024
Merged

[lexical-markdown] Bug Fix: add missing shouldPreserveNewLines to markdown flow #6165

merged 1 commit into from
May 23, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented May 23, 2024 •
edited
Loading

followup to #6020 , which introduces shouldPreserveNewLines flag . update the flow file to be in sync

@vercel Vercel
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:15am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:15am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 111 ms (+156.38% 🔺) 590 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 126 ms (-2.35% 🔽) 818 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 118 ms (+8.39% 🔺) 809 ms

@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 23, 2024
@potatowagon potatowagon added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 80398d0 May 23, 2024
39 of 45 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@potatowagon @zurfyx @Sahejkm @facebook-github-bot