Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(playground): wrong logic for FloatingLinkEditorPlugin bad node #5814

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix(playground): wrong logic for FloatingLinkEditorPlugin bad node #5814

merged 1 commit into from
Apr 12, 2024

Conversation

agriffis
Copy link
Contributor

@agriffis agriffis commented Apr 3, 2024

As discussed at #5551 (comment)

I suspect the lengthy original conditional was attempting to capture the definition of a bad node:

  • if we have either a focusLinkNode or a linkNode, it must match the other
  • if we have either a focusAutoLinkNode or an autoLinkNode, it must match the other

so I rewrote the logic to say that.

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 4:08pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 4:08pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
@agriffis
Copy link
Contributor Author

agriffis commented Apr 3, 2024

@HarrySIV It looks like I can't explicitly request a code review from you. Mind taking a gander?

@HarrySIV
Copy link
Contributor

HarrySIV commented Apr 3, 2024

LGTM

@thegreatercurve thegreatercurve merged commit 8597e53 into facebook:main Apr 12, 2024
45 checks passed
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agriffis @HarrySIV @thegreatercurve @facebook-github-bot