fix: Address more flaky collab tests #5788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
force-pushed
the
flaky-collab-tests
branch
from
4addc31 to
25d5f5f
Compare
etrepum
force-pushed
the
flaky-collab-tests
branch
from
25d5f5f to
754d572
Compare
etrepum
force-pushed
the
flaky-collab-tests
branch
from
754d572 to
6f73af5
Compare
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
etrepum
commented
Mar 31, 2024
Comment on lines
+106
to
+110
| // If there was a collision on the top level paragraph | ||
| // we need to re-add a paragraph | ||
| if ($getRoot().getChildrenSize() === 0) { | ||
| $getRoot().append($createParagraphNode()); | ||
| } |
There was a problem hiding this comment.
I had to bang my head against the wall for a very long time to figure out that this would fix the issue. I haven't read enough yjs and syncEvent code to figure out why it's doing the wrong thing (and that it's timing dependent!), but I don't see the harm in making sure that the editor doesn't become completely empty (since this code ran anyway under a more limited set of conditions).
ivailop7
approved these changes
Mar 31, 2024
acywatson
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to the reliability of collab tests