Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@lexical/text): Split into several files for better readability and to simplify further expansion #5718

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented Mar 15, 2024

It's time to do some housekeeping if we want to add more helpers there :)

… and to simplify further expansion

It's time to do some housekeeping if we want to add more helpers there :)

Signed-off-by: Vladlen Fedosov <vladlenfedosov@meta.com>
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 2:09pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 2:09pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2024
@acywatson
Copy link
Contributor

I don't mind this but let's hold off for a bit on merging until we get this ESM support release working.

@StyleT
Copy link
Contributor Author

StyleT commented Mar 21, 2024

@acywatson Hi! Do you think we can merge it now? Or if not - what is the blocking issue?

@acywatson acywatson merged commit 2793c5a into facebook:main Mar 21, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants