Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list selection when first node followed by an element node #5583

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Fix list selection when first node followed by an element node #5583

merged 8 commits into from
Feb 6, 2024

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Feb 3, 2024

Before:

checklist_divider.mp4

After:

fix_list_root_selection.mp4

Fixes: #5581

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 10:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 10:25pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2024
zurfyx
zurfyx previously approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, any chance we can have a test on this before merging?

@ivailop7
Copy link
Collaborator Author

ivailop7 commented Feb 4, 2024

Good one, any chance we can have a test on this before merging?

Of course

@ivailop7 ivailop7 merged commit b0c4087 into facebook:main Feb 6, 2024
42 of 45 checks passed
@ivailop7 ivailop7 deleted the broken_selection branch February 6, 2024 09:30
@2wheeh 2wheeh mentioned this pull request Feb 20, 2024
Closed
@2wheeh 2wheeh mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Adding a horizontal line under a list and selecting leads to a crash
3 participants
@ivailop7 @zurfyx @facebook-github-bot