refactor(playground): kill ts-ignore #5342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriffis
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
Thanks for this @agriffis! Would you mind fixing the conflict and I can merge this in. |
thegreatercurve
approved these changes
Dec 8, 2023
agriffis
force-pushed
the
refactor/ts-expect-error
branch
from
43eb332 to
edb9d85
Compare
|
@thegreatercurve Done. Note that this commit affects a file that should actually be deleted, see #5237 (comment) but merging this doesn't prevent that, it's just a question of ordering. 🤷 |
|
In fact, the reason the other PR went through cleanly was because |
|
Blech, I'll just update this PR to delete the file |
This was missed in facebook#5237 because of ts-ignore.
Replace with ts-expect-error where still needed.
agriffis
force-pushed
the
refactor/ts-expect-error
branch
from
edb9d85 to
150354f
Compare
|
Ok all set |
|
@thegreatercurve This has two commits now so it should be clear what's going on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with ts-expect-error where still needed.