URL sanitization ClickableLinkPlugin #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeion7
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
yeion7
commented
Nov 29, 2023
| @@ -61,7 +61,7 @@ export default function LexicalClickableLinkPlugin({ | |||
| $isElementNode, | |||
| ); | |||
| if ($isLinkNode(maybeLinkNode)) { | |||
| url = maybeLinkNode.getURL(); | |||
| url = maybeLinkNode.sanitizeUrl(maybeLinkNode.getURL()); | |||
There was a problem hiding this comment.
I'm thinking about whether it might be better to have sanitizeUrl within getURL so that getUrl always hands back a cleaned-up URL.
There was a problem hiding this comment.
There's probably a reason why I separated these things, but I can't remember exactly what it is. Maybe so you could override them separately?
How is this implemented elsewhere in the codebase? Let's just be consistent for now, I think.
There was a problem hiding this comment.
After digging into the codebase, I found that it sanitizes right after grabbing the URL, so I think we're good with the current approach.
acywatson
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though URLs undergo sanitization when the Link Node generates the DOM, when someone clicks a link using the ClickableLinkPlugin, the link isn't sanitized.
This pull request resolves the issue by sanitizing the URL within the event handler.