Support HTML export overrides from config for nested editors. #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
ivailop7
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were overriding the _nodes property for nested editors in LexicalNestedComposer, which meant that the HTML overrides weren't being passed through as expected.
I'm honestly not sure this conditional logic for copying over the nodes from the parent if initialNodes doesn't exist is correct - it seems like we'd want to check for any nodes already registered on the passed-in Editor instance before we just copy from the parent, but I'm not sure what other issues changing that may cause.
This adds support for copying over those overrides in either path. Note that to make this work for nested editors that specify different nodes than the parent, you need to define the initialNodes prop on LexicalNestedComposer.