Updated cell calculation based on cellspans #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icrosil
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
ivailop7
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Based on this issue with Tables current algorithm for resizing is out of shape for cases where cells are merged. What happens is it tries to map index from given active cell and make sure that it exists on each row, if not - throwing exception.
#4415
What changed
I've updated TableCellResizer to acomodate that - now it claculates length of row based on children and their cell span. From this we are finding which column corresponds to given active cell, that now always should be less or equal to active cell. After this we are using this column to set width.
Test:
lexical1.mov
E2E test - couldn't find a way to resize in unit/e2e test.