Update anchor selection if split by patching style #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piliuta
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
Failed tests seem spurious 😏 |
ivailop7
approved these changes
Oct 5, 2023
Piliuta
deleted the
update-anchor-selection-after-patching-range-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Setting styles using
$patchStyleTextdoes not update the selection when the anchor node is split. This causes the selection to contain a node that is not part of the selection. As a result, the toolbar/$getSelectionStyleValueForPropertyis not able to determine the correct selection style.Screen.Recording.2023-10-05.at.18.48.34.mov
Solution
Update the selection anchor with the new text node after splitting.
Screen.Recording.2023-10-05.at.18.52.00.mov