fix: fix android backspace bug

[cristopher-iov]

Context:

When this line editor.isComposing() is evaluated, the value returned is always false, so the code within the if is not executed and continues to the else.

This causes deleting a character on an Android device to delete the character on the right.

I was testing a bit and giving a value to the _compositionKey property fixes it.

I don't know if it's the best solution, but this could help or be a guide.

Issue: #4340

Evidence: https://www.loom.com/share/24898783cffd4023bf85460966702898

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 10:05pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 10:05pm

[facebook-github-bot]

Hi @cristopher-iov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[ivailop7]

These platform specific bugs always worry me, I wonder if a deeper bug is happening here, but don't know enough about mobile browsers and why this is not happening for iOS for example. Anyhow, please create IS_ANDROID in here: https://github.com/facebook/lexical/blob/main/packages/shared/src/environment.ts and use the variable from there in here.

[alexgleason]

Thank you for creating this PR @cristopher-iov

My users are annoyed by this bug. Merge?

[bilobom]

@ivailop7 @alexgleason
This PR is not the optimal solution , when there is one character left at any line it wont delete it and it will jump to the begining of line without deleting the character.

Evidence:
https://github.com/facebook/lexical/assets/19841175/50d93d4c-f6db-474a-bfb0-b63280e587da

[alexgleason]

The actual underlying issue here is a bug in Chromium Android, right?

Your comment here is very helpful: #1973 (comment)

Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1403455#c2

This MR is still mostly an improvement, but frustrating that mobile Chromium sucks at this. It's a big portion of my userbase.

[ivailop7]

Not great, let's see when this bug Chromium Android bug gets fixed and we'll revisit this. Don't know what the right answer is here.

[kirandash]

@ivailop7 @alexgleason This PR is not the optimal solution , when there is one character left at any line it wont delete it and it will jump to the begining of line without deleting the character.

Evidence: facebook/lexical/assets/19841175/50d93d4c-f6db-474a-bfb0-b63280e587da

I was able to fix it with these code changes: #4941 (comment)
Hope it helps. If anyone has any feedback I will be happy to investigate further 🙏🏻

[kazimirchuk]

@kirandash great job, thanks a lot! 🙇 Replied in the PR #4941 (comment) 🙏