Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column layout plugin example #4937

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add column layout plugin example #4937

merged 1 commit into from
Aug 30, 2023

Conversation

fantactuka
Copy link
Contributor

Another example of nested elements for columns layout plugin

Screen.Recording.2023-08-29.at.6.10.42.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2023
@vercel
Copy link

vercel bot commented Aug 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Aug 29, 2023 10:14pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 10:14pm

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 36.25 KB (0%) 726 ms (0%) 425 ms (-34.32% 🔽) 1.2 s
packages/lexical-rich-text/dist/LexicalRichText.js 39.06 KB (0%) 782 ms (0%) 510 ms (-23.32% 🔽) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.04 KB (0%) 781 ms (0%) 288 ms (-2.31% 🔽) 1.1 s

zurfyx
zurfyx approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not an example, that's the whole plugin 👀

@ivailop7
Copy link
Collaborator

@fantactuka This is fantastic! Thank you raising the PR!

@fantactuka fantactuka merged commit 1aa8c10 into main Aug 30, 2023
@acywatson acywatson mentioned this pull request Sep 7, 2023
Merged
@varun-s22
Copy link

hey @zurfyx whats the exportDOM here?
like i want to use this to generate HTML, and I'm not sure what html does this node outputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx zurfyx approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fantactuka @ivailop7 @varun-s22 @zurfyx @facebook-github-bot