fix: disable spellcheck for code format

[zignis]

Disables spellcheck for text nodes with code format.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 29, 2023 4:27am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 29, 2023 4:27am

[zurfyx]

Thanks! Should we also add a condition on LexicalCodeNode to handle code blocks?

You'll also need to update the E2E tests to reflect this new property

[zignis]

Thanks! Should we also add a condition on LexicalCodeNode to handle code blocks?

You'll also need to update the E2E tests to reflect this new property

I think LexicalCodeNode already handles this:

lexical/packages/lexical-code/src/CodeNode.ts

Line 106 in 0e7977e

element.setAttribute('spellcheck', 'false');

[zurfyx]

Thank you! I'll merge this. Any chance you can push another PR with the code block (CodeBlockNode)?

The first case should also be marked as non spellcheckable but it won't fall under the TextNode condition you added

[zignis]

Thank you! I'll merge this. Any chance you can push another PR with the code block (CodeBlockNode)?

The first case should also be marked as non spellcheckable but it won't fall under the TextNode condition you added

I'll look into it

[zignis]

@zurfyx the code element already has spellcheck=false:

Am i missing something here?