Keeping local comments and sharedCommentsArray orders in sync #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ebads67
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
fantactuka
approved these changes
Jun 29, 2023
fantactuka
approved these changes
Jun 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of CommentStore local comments and the shared comments array must be exactly the same. Otherwise, the order of comments may be different for different users, and most importantly the delete operation depends on it.
If the delta contains more than one insert (happens during the initial load of comments) the order of the comments is reversed. This PR fixes this issue by applying the inserts to the local comments in the reverse order.
This is a one line change. Turn on the ignore-whitespaces feature to review.