Context Menu Options Added #4713
Conversation
Shubhankerism
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
| new ContextMenuOption(`Delete Node`, { | ||
| onSelect: (_node) => { | ||
| const selection = $getSelection(); | ||
| if ($isRangeSelection(selection)) { | ||
| const currentNode = selection.anchor.getNode(); | ||
|
|
||
| const parentNode = $findMatchingParent(currentNode, (node) => { | ||
| return node.__parent === 'root'; | ||
| }); | ||
| parentNode?.remove(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Will this work for ImageNode which is an inline node? I presume that in this case it will still delete the entire paragraph?
There was a problem hiding this comment.
Hi, thanks for the review! :)
Yes, it will delete the entire paragraph, the current logic removes the node that has root as its parent.
| const currentNode = selection.anchor.getNode(); | ||
|
|
||
| const parentNode = $findMatchingParent(currentNode, (node) => { | ||
| return node.__parent === 'root'; |
There was a problem hiding this comment.
Nit; I would try to avoid the use of private properties beyond the core, so I'd probably use a combination of getParent and $isRootNode in this case. It's not the most performant but it's the recommended consumer-wise
There was a problem hiding this comment.
I have updated the logic to now use getParents().
packages/lexical-utils/src/index.ts
Outdated
| @@ -524,5 +524,7 @@ export function objectKlassEquals<T>( | |||
| object: unknown, | |||
| objectClass: ObjectKlass<T>, | |||
| ): boolean { | |||
| return Object.getPrototypeOf(object).constructor.name === objectClass.name; | |||
| return object | |||
There was a problem hiding this comment.
I presume you're checking null values here. Can we use triple equality?
| return object | |
| return typeof object === 'object' |
There was a problem hiding this comment.
Using object !== null as typeof null returned object.
| for (const type of item.types) { | ||
| const dataString = await (await item.getType(type)).text(); | ||
| data.setData(type, dataString); | ||
| } |
There was a problem hiding this comment.
Does this cover images? Can also be done in a follow-up PR
There was a problem hiding this comment.
Yes, I am able to copy paste images as well, the only case where it doesn't seem to work is when I try to copy paste the sample image that's provided when we try to upload an image. Will investigate this and do a follow up PR.
|
Waiting on @zurfyx to approve and merge. |
This PR adds cut, copy, paste, paste as plain text and delete node options to the context menu.
Demo:
