Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction : line 47 - create -> update #4704

Merged
merged 1 commit into from
Jun 25, 2023
Merged

correction : line 47 - create -> update #4704

merged 1 commit into from
Jun 25, 2023

Conversation

abhishekkumar35
Copy link
Contributor

@abhishekkumar35 abhishekkumar35 commented Jun 25, 2023 •
edited
Loading

Correction is needed. Update for change. Lexical being immutable can’t be recreated, only updated to insert new nodes.

@abhishekkumar35
correction : line 47 - create -> update
0fb0096 
Correction is needed. Update for change. Lexical can’t be recreated, only updated to insert new nodes.
@vercel
Copy link

vercel bot commented Jun 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 5:13am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 5:13am

@facebook-github-bot
Copy link
Contributor

Hi @abhishekkumar35!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2023
@ivailop7 ivailop7 merged commit 2bcf11b into facebook:main Jun 25, 2023
@zurfyx zurfyx mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekkumar35 @facebook-github-bot @ivailop7