Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delay from flakey E2E test #4676

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Remove delay from flakey E2E test #4676

merged 1 commit into from
Jun 20, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Jun 19, 2023 •
edited
Loading

Hopefully this fixes some flakey E2Es.

@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 2:06pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 2:06pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2023
@thegreatercurve thegreatercurve marked this pull request as ready for review June 19, 2023 14:04
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.95 KB (0%) 560 ms (0%) 85 ms (+104.7% 🔺) 644 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.98 KB (0%) 780 ms (0%) 110 ms (+28.25% 🔺) 890 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.95 KB (0%) 780 ms (0%) 83 ms (-6.4% 🔽) 862 ms

@thegreatercurve thegreatercurve changed the title Remove delay Remove delay from flakey E2E test Jun 19, 2023
@acywatson
Copy link
Contributor

Is there something specific that makes you think this would improve flakiness on this test?

zurfyx
zurfyx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping as it's the only test with a timeout on moveLeft, not sure why we need that but if we do other tests should probably be updated

@thegreatercurve thegreatercurve merged commit 21a3621 into main Jun 20, 2023
@fantactuka fantactuka deleted the bug/timeout-text-entry branch July 6, 2023 20:15
@zurfyx zurfyx mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thegreatercurve @acywatson @zurfyx @facebook-github-bot