Fix uuid bug in AutocompleteNode.clone()
#4592
Conversation
UUID and key should be stable when the node is cloned, but currently, the old key becomes the new UUID and a new key is regenerated. This feels like a simple typo that arose in the v2 rewrite a few months ago.
msdrigg
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @msdrigg! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I signed it about an hour ago but its not showing up yet idk why |
facebook-github-bot
added
the
CLA Signed
UUID and key should be stable when the node is cloned, but currently, the old key becomes the new UUID and a new key is regenerated.
This feels like a simple typo that arose in the v2 rewrite a few months ago.
Fixes #4589