Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow native shift+arrow selection work over decorator nodes #4584

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented May 31, 2023

When pressing SHIFT+UP or DOWN to create a range selection, we want this to work correctly, without being intercepted as part of the block cursor logic.

Fixes #4561

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2023
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 9:31pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 9:31pm

@thegreatercurve thegreatercurve force-pushed the bug/shift-arrow-selection-not-working branch from 85f1d46 to 2a132f9 Compare May 31, 2023 21:28
@github-actions
Copy link

github-actions bot commented May 31, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.89 KB (0%) 558 ms (0%) 61 ms (+37.55% 🔺) 619 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.82 KB (0%) 777 ms (0%) 33 ms (-34.72% 🔽) 810 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.8 KB (0%) 776 ms (0%) 50 ms (-14.32% 🔽) 826 ms

@thegreatercurve thegreatercurve changed the title Let shift arrow selection work Allow native shift+arrow selection work over decorator nodes May 31, 2023
@thegreatercurve thegreatercurve marked this pull request as ready for review May 31, 2023 21:29
@thegreatercurve thegreatercurve merged commit 28b1f04 into main Jun 1, 2023
@thegreatercurve thegreatercurve deleted the bug/shift-arrow-selection-not-working branch June 14, 2023 10:43
@zurfyx zurfyx mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Shift+Up and Shift+Down selection can skip DecoratorNodes between TextNodes
3 participants