Another approach to fixing the className cache #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
zurfyx,
fantactuka and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
zurfyx
approved these changes
May 30, 2023
| @@ -1014,6 +1014,14 @@ export function getCachedClassNameArray( | |||
| classNamesTheme: EditorThemeClasses, | |||
| classNameThemeType: string, | |||
| ): Array<string> { | |||
| if (classNamesTheme.__lexicalClassNameCache === undefined) { | |||
| classNamesTheme.__lexicalClassNameCache = {}; | |||
There was a problem hiding this comment.
Ah, because every other (nested) property is an object, I guess. It looks like one property is inexplicably typed as a Record, which might be how the whole theme should be typed, but let's revisit this when we discuss this issue more broadly later.
zurfyx
reviewed
May 30, 2023
| @@ -1022,7 +1030,7 @@ export function getCachedClassNameArray( | |||
| // applied to classList.add()/remove(). | |||
| if (typeof classNames === 'string') { | |||
There was a problem hiding this comment.
How does cache work for the nested ones? Or we don't really support this?
There was a problem hiding this comment.
That’s a good point. I’m gonna try to just get rid of this caching. It’s only here to make dealing with DOMTokenList APIs easier and still performant. It might have outlived it’s usefulness.
thegreatercurve
approved these changes
May 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "cache" for getCachedClassNameArray is the theme itself. We mutate the theme object provided in the initial config, which is problematic because it can cause runtime type errors when we're looking for a string when accessing the theme properties directly, but instead we get an array.
This approach (vs #4581 ) has the advantage of leveraging the theme to keep the cache scoped to the Editor, disadvantage of still mutating the theme object, although collision probability seems low.