Arrow up selection fix #4536 #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantactuka
requested review from
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
fantactuka
force-pushed
the
arrow-up-selection
branch
from
8f59f70 to
3aee02b
Compare
fantactuka
force-pushed
the
arrow-up-selection
branch
from
3aee02b to
d6f4655
Compare
fantactuka
commented
May 24, 2023
| @@ -375,7 +374,6 @@ test.describe('HTML Lists CopyAndPaste', () => { | |||
| await page.keyboard.press('Enter'); | |||
| await page.keyboard.press('Enter'); | |||
| await page.keyboard.press('ArrowUp'); | |||
| await moveLeft(page, 4); | |||
There was a problem hiding this comment.
This test was wrong as moving upward was broken
fantactuka
commented
May 24, 2023
| @@ -13,6 +13,7 @@ | |||
| position: relative; | |||
| outline: 0; | |||
| padding: 8px 28px 40px; | |||
| min-height: 150px; | |||
There was a problem hiding this comment.
Minor adjustments for mobile screen on a playground, not really a separate PR-worthy
fantactuka
force-pushed
the
arrow-up-selection
branch
from
d6f4655 to
3ad2fd4
Compare
zurfyx
approved these changes
May 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That condition looks a bit odd and is likely redundant or missing extra logic. Basically any shift + arrow-up selection will be broken if going into { canBeEmpty: false } (tables, lists). Original issue uses image as an example, but even list + paragraph case is broken:
Before:
Screen.Recording.2023-05-24.at.11.38.08.AM.mov
After:
Screen.Recording.2023-05-24.at.11.39.26.AM.mov