Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update-changelog not finishing #4537

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix update-changelog not finishing #4537

merged 1 commit into from
May 24, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented May 23, 2023 •
edited
Loading

Some weird characters in the changelog break the exec, let's allowlist the characters instead

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2023
@vercel
Copy link

vercel bot commented May 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 9:02pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 9:02pm

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.78 KB (0%) 556 ms (0%) 345 ms (+40.84% 🔺) 900 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.71 KB (0%) 775 ms (0%) 440 ms (+59.18% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.69 KB (0%) 774 ms (0%) 263 ms (-65.93% 🔽) 1.1 s

@fantactuka fantactuka merged commit 0a4886d into main May 24, 2023
@fantactuka fantactuka deleted the ccc branch May 24, 2023 17:22
@zurfyx zurfyx mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @fantactuka @facebook-github-bot