Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clickable link plugin #4514 #4519

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix clickable link plugin #4514 #4519

merged 1 commit into from
May 19, 2023

Conversation

fantactuka
Copy link
Contributor

Add missing null check, adjust dom traversal util

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2023
@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 1:52pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 1:52pm

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 27.25 KB (0%) 545 ms (0%) 264 ms (-21.98% 🔽) 809 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.2 KB (0%) 764 ms (0%) 385 ms (-14.84% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.17 KB (0%) 764 ms (0%) 320 ms (-10.17% 🔽) 1.1 s

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is #4447 relevant after this one?

@fantactuka
Copy link
Contributor Author

Is #4447 relevant after this one?

Ugh, I missed that one. No hard feelings if need to close mine

@zurfyx zurfyx merged commit bead8fe into main May 19, 2023
@zurfyx zurfyx deleted the clickable-link branch May 19, 2023 15:44
vuamitom pushed a commit to bitbriks/lexical that referenced this pull request May 19, 2023
This was referenced May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants