Change MarkNode::clone node arg type to this
#4363
Conversation
potomak
requested review from
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @potomak! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| @@ -22,7 +22,7 @@ export type SerializedMarkNode = SerializedElementNode & { | |||
| declare export class MarkNode extends ElementNode { | |||
| __ids: Array<string>; | |||
|
|
|||
| static clone(node: MarkNode): MarkNode; | |||
| static clone(node: this): MarkNode; | |||
There was a problem hiding this comment.
Didn't realize you can do that 😳
|
I signed the CLA, can you rerun that action please? |
Ignore my last comment about re-running the CLA signature action :) |
|
Seems like we should be doing this for other nodes though, if it's good for one |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
Subclasses of
MarkNodecan't overrideclonewithout adding a Flow type error ignore annotation without this change.