-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube embed: use more privacy-friendly youtube-nocookie.com instead of youtube.com #4282
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LGTM, mind looking into the failing checks? Not too sure why it's failing, might be a bad rebase or something |
should hopefully be good now. One test was checking for youtube.com/embed instead of youtube-nocookie.com/embed. As for this: This seems to potentially be a bug with the npm run ci-check command itself. At least I cannot explain it otherwise. This is how the command is defined:
When I run tsc, flow, prettier and lint one by one manually, everything passes successfully. Thus, this might be an issue with npm-run-all? |
This is a tricky one - npm run prettier actually runs with the flag --list-different, I think. The output is confusing. Try npm run prettier:fix and then git status to see if anything changed. |
Europeans will be happy!