Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube embed: use more privacy-friendly youtube-nocookie.com instead of youtube.com #4282

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

AlessioGr
Copy link
Contributor

@AlessioGr AlessioGr commented Apr 7, 2023

Europeans will be happy!

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 9:43pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 9:43pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2023
@zurfyx
Copy link
Member

zurfyx commented Apr 7, 2023

LGTM, mind looking into the failing checks? Not too sure why it's failing, might be a bad rebase or something

@AlessioGr
Copy link
Contributor Author

AlessioGr commented Apr 7, 2023

LGTM, mind looking into the failing checks? Not too sure why it's failing, might be a bad rebase or something

should hopefully be good now. One test was checking for youtube.com/embed instead of youtube-nocookie.com/embed. As for this:

Arc 2023-04-07 at 22 50 03@2x

This seems to potentially be a bug with the npm run ci-check command itself. At least I cannot explain it otherwise. This is how the command is defined:

"ci-check": "npm-run-all --parallel tsc flow prettier lint",

When I run tsc, flow, prettier and lint one by one manually, everything passes successfully. Thus, this might be an issue with npm-run-all?

@AlessioGr
Copy link
Contributor Author

Visual Studio Code 2023-04-07 at 22 54 56@2x

Running "npm run prettier" manually - no issues!

@acywatson
Copy link
Contributor

Running "npm run prettier" manually - no issues!

This is a tricky one - npm run prettier actually runs with the flag --list-different, I think. The output is confusing.

Try npm run prettier:fix and then git status to see if anything changed.

@AlessioGr
Copy link
Contributor Author

Running "npm run prettier" manually - no issues!

This is a tricky one - npm run prettier actually runs with the flag --list-different, I think. The output is confusing.

Try npm run prettier:fix and then git status to see if anything changed.

Aah, I see, found the issue! Yeah, that output is confusing indeed. Should be good now!

Do you by any chance know why VS Code doesn't automatically set prettier as the default formatter when I open the project? If I set it to prettier manually, it wants to do this to the settings.json:
Visual Studio Code 2023-04-07 at 23 42 09@2x

@acywatson
Copy link
Contributor

Running "npm run prettier" manually - no issues!

This is a tricky one - npm run prettier actually runs with the flag --list-different, I think. The output is confusing.
Try npm run prettier:fix and then git status to see if anything changed.

Aah, I see, found the issue! Yeah, that output is confusing indeed. Should be good now!

Do you by any chance know why VS Code doesn't automatically set prettier as the default formatter when I open the project? If I set it to prettier manually, it wants to do this to the settings.json: Visual Studio Code 2023-04-07 at 23 42 09@2x

I have no idea...you can probably commit that if it'd be helpful.

@zurfyx zurfyx merged commit c23fff3 into facebook:main Apr 10, 2023
@acywatson acywatson mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants