Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flowtypes for insertBefore/after #4245

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Fix flowtypes for insertBefore/after #4245

merged 1 commit into from
Apr 10, 2023

Conversation

fantactuka
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Mar 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 9:30pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 9:30pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Mar 30, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.94 KB (0%) 539 ms (0%) 246 ms (+23.01% 🔺) 785 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.8 KB (0%) 756 ms (0%) 198 ms (-6.35% 🔽) 954 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.77 KB (0%) 756 ms (0%) 293 ms (-9.99% 🔽) 1.1 s

@thegreatercurve
Copy link
Contributor

@fantactuka See related integrity check failing due to Window being undefined.

@fantactuka fantactuka merged commit 933ec6a into main Apr 10, 2023
@acywatson acywatson mentioned this pull request Apr 14, 2023
Merged
@fantactuka fantactuka deleted the flow-types branch July 6, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantactuka @thegreatercurve @zurfyx @facebook-github-bot