Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table insertion #4180

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix table insertion #4180

merged 1 commit into from
Mar 27, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 22, 2023

The current logic didn't handle selection restoration properly when selection was null. Leveraging insertNodeToNearestRoot will make table E2E tests less flaky

@vercel
Copy link

vercel bot commented Mar 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview Mar 22, 2023 at 9:12PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 9:12PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2023
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 316 ms (-14.77% 🔽) 853 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.68 KB (0%) 754 ms (0%) 513 ms (+55.17% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.66 KB (0%) 754 ms (0%) 221 ms (-78.01% 🔽) 975 ms

@zurfyx zurfyx merged commit d524b3f into main Mar 27, 2023
@zurfyx zurfyx mentioned this pull request Apr 6, 2023
Closed
@acywatson acywatson mentioned this pull request Apr 14, 2023
Merged
@fantactuka fantactuka deleted the table-insertion branch July 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @fantactuka @facebook-github-bot