Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit E2E_BROWSER on E2E runs #4179

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Explicit E2E_BROWSER on E2E runs #4179

merged 1 commit into from
Mar 23, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 22, 2023

Haven't fully checked how we use this variable but somehow having this implicit produces different results than the debug version with explicit E2E_BROWSER

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2023
@vercel
Copy link

vercel bot commented Mar 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 8:44PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 8:44PM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 371 ms (-2.95% 🔽) 908 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.68 KB (0%) 754 ms (0%) 320 ms (-21.52% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.66 KB (0%) 754 ms (0%) 188 ms (-47.48% 🔽) 941 ms

@zurfyx zurfyx merged commit 607263e into main Mar 23, 2023
zurfyx added a commit that referenced this pull request Mar 24, 2023
@zurfyx
Explicit E2E_BROWSER on E2E runs (#4179)
2beb8ce
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the pack branch July 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @thegreatercurve @facebook-github-bot