Remove rows w/ span support #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
trueadm,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tylerjbainbridge
approved these changes
Mar 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given our rectangular selection that can automatically span beyond the initial intended selection, the best UX friendly algo to remove rows seems to be Apple Pages: we remove all rows that are contained within the selection and if there are conflicting merged cells beyond the selection we trim those cells.
Surprisingly, Quip, which does rectangular selection decided to just simply remove the row itself (trimming the selected node instead) (which imo can get confusing when it's a merged cell). This makes more sense on a GDoc approach as they don't guarantee rectangular selection.
Screen.Recording.2023-03-09.at.11.27.50.AM.mov
Screen.Recording.2023-03-09.at.11.55.21.AM.mov